adobe / aepsdk-assurance-ios

Adobe Experience Platform Assurance SDK

Apache License 2.0

1 stars 12 forks source link

[MOB-16690] Cover missed edge case #67

Closed cdhoffmann closed 1 year ago

cdhoffmann commented 1 year ago

@prudrabhat Mentioned that i missed an edge case in my PR #66 where extra query parameters could be added into the socket url with malicious JS injected.

Changed the implementation to cover for this case and added a test case.

codecov[bot] commented 1 year ago

Codecov Report

Merging #67 (3a1c9ae) into dev (42531df) will increase coverage by 0.07%. The diff coverage is 95.45%.

@@            Coverage Diff             @@
##              dev      #67      +/-   ##
==========================================
+ Coverage   88.71%   88.78%   +0.07%     
==========================================
  Files          32       32              
  Lines        1364     1373       +9     
==========================================
+ Hits         1210     1219       +9     
  Misses        154      154