Closed timkimadobe closed 1 year ago
Merging #402 (1b1456e) into feature/json-comparison-parity (d7e511e) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## feature/json-comparison-parity #402 +/- ##
===============================================================
Coverage 96.77% 96.77%
===============================================================
Files 27 27
Lines 1671 1671
===============================================================
Hits 1617 1617
Misses 54 54
Description
This PR splits test coverage into parameterized and unit test cases, and provides more comprehensive, systematic coverage of the JSON comparison feature. It brings the iOS implementation in line with the latest Android changes.
Please see https://github.com/adobe/aepsdk-edge-android/pull/79 for reference, specifically:
Question for reviewers: The parameterized tests use
XCTContext.runActivity
to create separate test cases, however errors in Xcode are presented differently; now the left side panel Test navigator that shows the individual test cases serves as an overall pass/fail indicator for the whole group of parameterized tests - is this an acceptable change? Are there any other format or logging updates that are required in this case?and individual parameterized test cases can be seen in the Report navigator.
The following is an example of the console output that would be seen in Xcode and CI systems:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: