adobe / aepsdk-edge-ios

Adobe Experience Platform Edge Network mobile extension in Swift
Apache License 2.0
13 stars 24 forks source link

Refactor unit test cases to use JSON comparison (part 2) #436

Closed timkimadobe closed 9 months ago

timkimadobe commented 10 months ago

[!NOTE] This is the second part in a multi-part series of PRs that will refactor existing Edge extension unit and functional tests to use the JSON comparison tool from AEPTestUtils See part 1: #434 (Please merge part 1 first, as this branch incorporates its changes.)

Description

This PR refactors the rest of the Edge extension unit tests to use the test helper utilities from AEPTestUtils

Questions for reviewers

In RequestBuilderTests.swift testGetPayloadWithExperienceEvents_withEventXdm_verifyEventId_verifyTimestamp and testGetPayloadWithExperienceEvents_withQuery_responseContainsQuery

  1. Was it intended to not do a count check? There was no element count check post-flattening (pre-migration). To mirror this non-strict element check the JSON comparison currently does an extensible comparison instead of strict equality.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 9 months ago

Codecov Report

Merging #436 (755f323) into dev (2c9403f) will not change coverage. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #436 +/- ## ======================================= Coverage 96.47% 96.47% ======================================= Files 27 27 Lines 1730 1730 ======================================= Hits 1669 1669 Misses 61 61 ```