adobe / aepsdk-edge-ios

Adobe Experience Platform Edge Network mobile extension in Swift
Apache License 2.0
13 stars 24 forks source link

Integration test - parameterized mobile property ID #491

Open timkimadobe opened 1 week ago

timkimadobe commented 1 week ago

[!NOTE] This change is intended to match the Android PR: https://github.com/adobe/aepsdk-edge-android/pull/163

Description

This PR updates the integration tests to accept a parametrized mobile property ID instead of the old environment switcher. It involves:

  1. Changes to the entire testing pipeline to apply these changes: GitHub workflow -> Makefile -> Integration test
  2. Replacing custom enums for location hint and edge environment with a more streamlined test constants + test environment helper

Questions for reviewers

  1. Should the modified TestEnvironment struct be merged with the extension TestBase in TestBase+EdgeHelpers.swift? Or does it make more sense to keep these separate?
  2. Do we like having a dropdown picker for location hint in the workflow or should it be an open String input?
    • The downstream implication of the current picker is that any other option would require a code change
    • Using an open String input would also allow removing the special case handling enum LocationHintMapping

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist: