swarna04 commented 2 years ago

Description

Ref: [MOB-16753], [MOB-16754]

Added Target session Id getter and setter APIs in the SDK to support hybrid implementations.

Added new public APIs getSessionId and setSessionId
Added unit, functional and integration tests to verify the functionality.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

codecov[bot] commented 2 years ago

Codecov Report

Merging #115 (53a58b5) into dev-v3.2.0 (e2b4fda) will decrease coverage by 0.27%. The diff coverage is 85.07%.

@@              Coverage Diff               @@
##           dev-v3.2.0     #115      +/-   ##
==============================================
- Coverage       90.40%   90.13%   -0.27%     
==============================================
  Files              24       24              
  Lines            1261     1307      +46     
==============================================
+ Hits             1140     1178      +38     
- Misses            121      129       +8

swarna04 commented 2 years ago

can we also update the objc test app with these new apis?

The objC test app is updated for both sessionId and tntId as part of the other pr https://github.com/adobe/aepsdk-target-ios/pull/116.

adobe / aepsdk-target-ios

Added support for Target session Id setter & getter #115