search

adobe / aepsdk-target-ios

Adobe Experience Platform - Target extension built with Swift
Apache License 2.0
0 stars 15 forks source link

[Discussion] several review comments for Prefetch code #39

Closed yangyansong-adbe closed 3 years ago

yangyansong-adbe commented 3 years ago
  1. https://github.com/adobe/aepsdk-target-ios/pull/11#discussion_r579451157
  2. https://github.com/adobe/aepsdk-target-ios/pull/11#discussion_r578662766
  3. https://github.com/adobe/aepsdk-target-ios/pull/41#discussion_r587900487
yangyansong-adbe commented 3 years ago

@swarna04 for above review comments, I think we don't need to fix the # 1 and # 2. I will fix the # 3 in a separate PR. Let me know, if you have any concerns.

swarna04 commented 3 years ago

I believe we should fix # 1 too, especially when we already expose the setting via System Info. We should try not to hardcode stuff as much as possible. But if you still feel otherwise, go ahead with only # 3.