Target Identifiers, Session Management APIs and handling configuration response - Githubissues

adobe / aepsdk-target-ios

Adobe Experience Platform - Target extension built with Swift

Apache License 2.0

0 stars 15 forks source link

Target Identifiers, Session Management APIs and handling configuration response #47

Closed ravjain-adb closed 3 years ago

ravjain-adb commented 3 years ago

Description

Public api updates for setting and getting ids
Updated edge host getter based on session expiry
Handle configuration response

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

swarna04 commented 3 years ago

Multiple TestableExtensionRuntime.swift are present, it can lead to compilation issues. https://github.com/adobe/aepsdk-target-ios/blob/dev/AEPTarget/Tests/Mocks/TestableExtensionRuntime.swift https://github.com/adobe/aepsdk-target-ios/blob/dev/AEPTarget/Tests/TestHelpers/TestableExtensionRuntime.swift

Can you please clean it up @ravjain-adb