search

adobe / aepsdk-userprofile-ios

Adobe Experience Platform - User Profile extension built with Swift
Apache License 2.0
1 stars 12 forks source link

make archive fails to build #38

Closed markph0204 closed 2 years ago

markph0204 commented 2 years ago

Expected Behavior

After running make archive, we expect the build to not fail and output frameworks to the build path.

Actual Behavior

Makefile fails to build XCFramework's successfully.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

  1. Get project fresh (git clone) from this repo.
  2. run make archive from terminal

Platform and Version

Mac OS version Big Sur 11.6.1 using Xcode 13.1

Sample Code that illustrates the problem

Not code related.

Logs taken while reproducing problem

Corrective action is suggested in two areas:

  1. Notify the user to run pod install in the README.md file
  2. the swiftformat dependency is missing, and is needed to complete archive. Suggest the user not be required to install it themselves, since CocoaPods is being used for other. Instead leverage CocoaPods to also install swiftformat dependency. This also includes a subtle change in XCodeProject to use swiftformat installed in PODS rather than environment. This affords you with ability to "pin" a specific swiftformat version in future as well for compatibility reasons if ever needed.

Also noteworthy -- why is this repo using swiftformat while other Adobe modules are using SwiftLint? Consistency?

cdhoffmann commented 2 years ago

Thank you for filing this. It has been fixed as of #40