adobe / aepsdk_flutter

Apache License 2.0
10 stars 12 forks source link

Add "FullscreenMessageActivity" and "LocalNotificationHandler" to the AEPCore AndroidManifest.xml #7

Closed cacheung closed 1 year ago

cacheung commented 2 years ago

In AEPCore AndroidManifest file, we don't have "FullscreenMessageActivity" activity and "LocalNotificationHandler" receiver. They will be used by messaging, campaign, etc.

Expected Behaviour

In https://github.com/adobe/aepsdk_flutter/blob/main/plugins/flutter_aepcore/android/src/main/AndroidManifest.xml, include

<application>
        <activity
            android:name="com.adobe.marketing.mobile.FullscreenMessageActivity"
            android:exported="false" />
        <receiver
            android:name="com.adobe.marketing.mobile.LocalNotificationHandler"
            android:exported="false" />
 </application>

Actual Behaviour

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

praveek commented 1 year ago

We don't have to add them to Core manifest. FullscreenMessageActivity has been removed from Android Mobile Core SDK v2.0. If an app depends on campaign/messaging/target, LocalNotificationHandler should be added directly to the app's manifest.