search

adobe / aepsdk_flutter

Apache License 2.0
8 stars 11 forks source link

Support for AGP 8.2.0 #85

Closed har5hit closed 2 months ago

har5hit commented 6 months ago

Expected Behaviour

Library should be easily integrated in project using Android Gradle plugin 8.2.0.

Actual Behaviour

Library throwing error due to non compatibility with AGP 8.2.0

Reproduce Scenario

Create a sample Flutter project with flutter_aepcore library and update AGP in android build.gradle with classpath 'com.android.tools.build:gradle:8.2.0' and gradle version in gradle-wrapper.properties file to 8.2, after that when trying to build apk, it will throw below error

A problem occurred configuring project ':flutter_aepcore'.
> Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
   > Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

     If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

Solution

Please set namespace in build.gradle following steps in https://d.android.com/r/tools/upgrade-assistant/set-namespace

egonm12 commented 5 months ago

Any update on this one? It shouldn't be much work and is preventing us from upgrading Flutter to 3.16.

cacheung commented 5 months ago

@egonm12 We don't have a timeline for supporting this yet. We are aware of this requirement.
Since this is an Open Source project, you are welcome to make the updates.

egonm12 commented 4 months ago

@cacheung I opened a pull request #88

cacheung commented 4 months ago

@egonm12 Thanks for the contribution, we are discussing the PR internal and will get back to you once a decision is made.

egonm12 commented 3 months ago

@cacheung any updates?

cacheung commented 3 months ago

@egonm12 We're looking to incorporate the namespace update in our plans for Q2. In the meantime, you can use it through a local package with your changes. We will keep you updated. Thanks!

cacheung commented 2 months ago

@har5hit @egonm12 , the namespace support for Android has been released with aepsdk_flutter plugins version 4.0.1.

@egonm12 , thanks again for your contribution!

We are going to close this ticket. Please feel free to open a new one if you have more questions.