adobe / aio-apps-action

GitHub action to perform aio app build test deploy workflows
https://www.adobe.io
Apache License 2.0
4 stars 8 forks source link

Improve scope environment variable handling #39

Closed MichaelGoberling closed 9 months ago

MichaelGoberling commented 1 year ago

Right now, using the SCOPE environment variable is not intuitive. When requesting one scope, users can submit a single value. However, when requesting multiple scopes, users have to create a secret in their repository where the scopes they'd like to request are enclosed in brackets and double-quoted:

GitHub Secret

["scope1", "scope2"]

Not only should this be documented, but users should be able to create their SCOPE secret with a variety of syntaxes. The following are all reasonable:

MichaelGoberling commented 1 year ago

Here's a quick PR for updating the README to help users until we make code changes to allow a variety of syntaxes: https://github.com/adobe/aio-apps-action/pull/40

aiojbot commented 1 year ago

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2548