adobe / aio-apps-action

GitHub action to perform aio app build test deploy workflows
https://www.adobe.io
Apache License 2.0
4 stars 8 forks source link

feat: add default scopes, make scope configuration optional (jwt only) #44

Closed MichaelGoberling closed 9 months ago

MichaelGoberling commented 11 months ago

Description

Related Issue

https://github.com/adobe/aio-apps-action/issues/42

Motivation and Context

How Has This Been Tested?

Set up this action in a personal repo and pointed it to this branch

(These could probably be unit tests of some sort)

Successful deploy with default scopes

Successful deploy with configured scopes

Failed deploy, configured scopes have wrong format

Failed deploy, credential doesn't have access to the requested scopes

Screenshots (if appropriate):

Types of changes

Checklist:

MichaelGoberling commented 11 months ago

Converted this to a draft for now as we discuss with product what this should look like

MichaelGoberling commented 11 months ago

Marking this as ready for review again as we are now checking the formatting of the SCOPES environment variable and outputting helpful error messages