adobe / aio-apps-action

GitHub action to perform aio app build test deploy workflows
https://www.adobe.io
Apache License 2.0
4 stars 8 forks source link

feat: validate oauth scope format #51

Closed MichaelGoberling closed 7 months ago

MichaelGoberling commented 7 months ago

Description

Use a regex to validate the oauth scopes format (comma-separated list with no quotes/double-quotes)

(Note: scope validation is already supported with the deprecated jwt step, this is bringing oauth up to par with that)

Related Issue

ACNA-2762

Motivation and Context

How Has This Been Tested?

npm run test

Real valid scope format run

Real invalid scope format run

Real invalid scope format run, specifically using the deprecated jwt format

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c18dda0) 100.00% compared to head (6c47447) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #51 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 102 104 +2 Branches 17 17 ========================================= + Hits 102 104 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.