search

adobe / aio-cli-plugin-app-dev

App Builder CLI - dev command
Apache License 2.0
0 stars 2 forks source link

missing important test for web server port #43

Closed shazron closed 3 months ago

shazron commented 4 months ago

The VS Code config relies on parsing the stdout log, for a certain phrase, to get the port the dev server runs on. There is no unit test to make sure the text has not been modified, which will break the VS Code launch config operation for web browser debugging if it was modified.

The phrase: https://github.com/adobe/generator-aio-app/blob/34ed1e9a686df70ce31be014beee4c84cab38c45/test/__fixtures__/add-vscode-config/launch.json#L19

The code: https://github.com/adobe/aio-cli-plugin-app-dev/blob/c05809d47f4a65c5c5844339a8d7a9b77d738acc/src/lib/run-dev.js#L182

aiojbot commented 4 months ago

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2993

shazron commented 3 months ago

closed by #49