feat: `aio app pack` command

adobe / aio-cli-plugin-app

Create, Build and Deploy Cloud Native Applications

Apache License 2.0

19 stars 35 forks source link

feat: `aio app pack` command #650

Closed shazron closed 1 year ago

shazron commented 1 year ago

(this is based on the WIP PoC for the aio app package command)

depends on https://github.com/adobe/aio-cli-plugin-api-mesh/pull/61 (worked around, for now)
- the PR has been merged, but not released in a new plugin release

How Has This Been Tested?

npm test

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 1 year ago

Codecov Report

Merging #650 (25ef7b9) into master (af0612f) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master      #650    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           54        55     +1     
  Lines         2849      2955   +106     
  Branches       538       554    +16     
==========================================
+ Hits          2849      2955   +106

Impacted Files	Coverage Δ
src/lib/import-helper.js	`100.00% <ø> (ø)`
src/commands/app/pack.js	`100.00% <100.00%> (ø)`
src/lib/app-helper.js	`100.00% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

shazron commented 1 year ago

I'm on Windows, and it was all passing -- had to reclone the repo and, npm i and npm test again to see the Windows errors (related to line endings).

shazron commented 1 year ago

Looks good, I left a couple nits. We may need to move around the pre-pack/post-pack hook timing.

@purplecabbage Is this a change we need in this PR? What changes are needed?

Also, should we skip cleaning up the output dir? While we are developing/integrating it might be good to have this easily inspectable. We do a similar thing with zipped actions where we do not discard the files so developers can easily see what is going in the zip.

We don't clean it up after the command is done - we only clean up at the start of the command

shazron commented 1 year ago

I'll merge this first thing tomorrow and do more testing, which will include #662