search

adobe / aio-cli-plugin-app

Create, Build and Deploy Cloud Native Applications
Apache License 2.0
19 stars 35 forks source link

Errors in tests #668

Open purplecabbage opened 1 year ago

purplecabbage commented 1 year ago

There are a bunch of cases where we mock command.error using command.error = jest.fn() The oclif behavior of command.error is to exit, however our mock simply swallows the error and continues. This means we have a whole bunch of places where we are testing for arguments and calls to functions that should never have happened because command.error should have exited.

Simply removing the mock in deploy.test.js reveals 38 errors, which are all invalid tests and need to be written.

aiojbot commented 1 year ago

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2242