adobe / aio-cli-plugin-app

Create, Build and Deploy Cloud Native Applications
Apache License 2.0
19 stars 35 forks source link

App Config Schema for aio app pack is outdated #709

Closed moritzraho closed 1 year ago

moritzraho commented 1 year ago

Describe the bug The file should be taken from https://github.com/adobe/aio-cli-lib-app-config/blob/master/schema/app.config.yaml.schema.json

682 is fixing this but it is still in discussion as it is a breaking change. It could be preferable to come up with an intermediate update just for the app pack command.

aiojbot commented 1 year ago

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2443

MichaelGoberling commented 1 year ago

@moritzraho Is there an update on this? Was testing aio app install for the EQP checks and noticed it doesn't fail the app.config.yaml schema validation check for extensions. I think this is because the config files aren't coalesced before the schema is validated

moritzraho commented 1 year ago

@MichaelGoberling fixed in #723