adobe / aio-cli-plugin-app

Create, Build and Deploy Cloud Native Applications
Apache License 2.0
19 stars 35 forks source link

feat: add code download annotation during install #711

Closed MichaelGoberling closed 1 year ago

MichaelGoberling commented 1 year ago

Description

Currently, the code-download (Now disable-download) annotation is added to all actions when an app is packed (aio app pack) to prevent users who install App Builder apps from downloading action code

This PR proposes adding the annotation at install time (aio app install) instead

Related Issue

Motivation and Context

Users can technically modify the app zip after aio app pack has run. This change guarantees that all installed App Builder apps have action code download disabled

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #711 (364ae15) into master (a427f0c) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #711   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3167      3169    +2     
  Branches       596       596           
=========================================
+ Hits          3167      3169    +2     
Files Changed Coverage Δ
src/commands/app/install.js 100.00% <100.00%> (ø)
src/commands/app/pack.js 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more