adobe / aio-cli-plugin-app

Create, Build and Deploy Cloud Native Applications
Apache License 2.0
19 stars 35 forks source link

remove isv dev details from mesh config while packing #716

Closed MichaelGoberling closed 1 year ago

MichaelGoberling commented 1 year ago

Description

This PR removes application developer details from the meshConfig portion of deploy.yaml, generated when the developer runs aio app pack

The api-mesh get command returns information about the application developer, which can be omitted from deploy.yaml since a new mesh config can be created with only the data in the meshConfig key

{
  "lastUpdated": "2023-08-29T16:20:01.202Z",
  "meshConfig": {
    "sources": [
      {
        "name": "Commerce",
        "handler": {
          "graphql": {
            "endpoint": "https://venia.magento.com/graphql/"
          }
        }
      }
    ]
  },
  "meshId": "ee487aab-e92e-4035-a757-e18858ef7a92",
  "lastUpdatedBy": {
    "firstName": "Michael",
    "lastName": "Goberling",
    "userEmail": "mgoberling@adobe.com",
    "userId": "4E561E5C62E3F21E0A494122@AdobeID",
    "displayName": "Michael%20Goberling"
  },
  "meshStatus": "success",
  "meshURL": ""
}

Related Issue

Motivation and Context

Security

How Has This Been Tested?

npm run test, locally linked plugin

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #716 (e346e45) into master (682f103) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #716   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3199      3199           
  Branches       603       603           
=========================================
  Hits          3199      3199           
Files Changed Coverage Δ
src/commands/app/pack.js 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more