adobe / aio-cli-plugin-app

Create, Build and Deploy Cloud Native Applications
Apache License 2.0
19 stars 35 forks source link

Revert "feat: add code download annotation during install (#711)" #717

Closed MichaelGoberling closed 1 year ago

MichaelGoberling commented 1 year ago

This reverts commit fd8d39512c1cf4c7ddf3d731d1ffe5cc68b536ac

Description

This commit broke installing app packages in a directory that doesn't already have .aio and package.json, because the this.getFullConfig() call requires them

We can instead copy the code for adding the annotation to the provisioner service and do it after we've installed / downloaded the workspace config

Related Issue

Motivation and Context

How Has This Been Tested?

npm run test, locally linked plugin

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #717 (e44dea2) into master (0b7d887) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #717   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3199      3197    -2     
  Branches       603       603           
=========================================
- Hits          3199      3197    -2     
Files Changed Coverage Δ
src/commands/app/install.js 100.00% <ø> (ø)
src/commands/app/pack.js 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more