adobe / aio-cli-plugin-app

Create, Build and Deploy Cloud Native Applications
Apache License 2.0
19 stars 35 forks source link

align action and package string requirements with openwhisk schema #718

Closed MichaelGoberling closed 1 year ago

MichaelGoberling commented 1 year ago

Description

The api-mesh template includes an action name that's above 20 characters (api-mesh-query-content, 22), so it's currently failing when run with aio app install

~I couldn't find any limits on Runtime action names, and deploying extremely long names (500+ chars) seems to be working~

~This is a conservative bump just for the use case I encountered. I also didn't bump packages, inputs, etc. to keep the changes minimal~

I updated the schema to be consistent with the validation Openwhisk does on the server: https://github.com/apache/openwhisk/blob/master/docs/reference.md#fully-qualified-names

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #718 (f42540f) into master (56a0dd5) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #718   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3197      3197           
  Branches       603       603           
=========================================
  Hits          3197      3197           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more