ACNA-2505: packed application version must follow X.Y.Z format

adobe / aio-cli-plugin-app

Create, Build and Deploy Cloud Native Applications

Apache License 2.0

19 stars 35 forks source link

ACNA-2505: packed application version must follow X.Y.Z format #722

Closed moritzraho closed 1 year ago

moritzraho commented 1 year ago

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 1 year ago

Codecov Report

Merging #722 (9c18101) into master (8ca5a88) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #722   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3197      3199    +2     
  Branches       603       604    +1     
=========================================
+ Hits          3197      3199    +2

Files Changed	Coverage Δ
src/commands/app/pack.js	`100.00% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

MichaelGoberling commented 1 year ago

~What do you think about referencing the pattern from deploy.yaml.schema.json for use in the pack command?~