ACNA-2443: partial lib app config update for install and pack

moritzraho commented 1 year ago

Description

NOTE this is only a partial update because app pack and app install need to validate the user configuration against a schema. The schema tracked in app plugin is outdated and the current validation logic doesn't resolve $included files. The schema and validation logic is now part of app config lib.

A reason to not yet do a full update is to avoid validating the schema on every command before we expose the schema version to the config or at least support a no validation option. This requires further discussion with the team.

Related Issue

https://github.com/adobe/aio-cli-plugin-app/issues/709 deferred related PR #682

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 1 year ago

Codecov Report

Merging #723 (ed50ebb) into master (726ffe7) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #723   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3199      3207    +8     
  Branches       604       605    +1     
=========================================
+ Hits          3199      3207    +8

Files Changed	Coverage Δ
src/commands/app/install.js	`100.00% <100.00%> (ø)`
src/commands/app/pack.js	`100.00% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

shazron commented 1 year ago

@moritzraho conflicts that can't be resolved via Github UI

adobe / aio-cli-plugin-app