adobe / aio-cli-plugin-app

Create, Build and Deploy Cloud Native Applications
Apache License 2.0
19 stars 35 forks source link

aio app pack: handle errors from pre-pack hook #725

Closed sangeetha5491 closed 10 months ago

sangeetha5491 commented 1 year ago

Describe the bug When there is an error in the pre-pack hooks, aio app pack continues to ignore the error and package the app. The app needs to abort packaging when an error is reported from a pre-pack hook

To Reproduce Steps to reproduce the behavior:

  1. Check out https://github.com/adobe/aio-cli-plugin-events/pull/81
  2. link to aio cli
  3. run aio app pack on an existing app with event registrations with invalid events of interest
  4. Run aio app pack

Expected behavior Error in pre-pack hook should abort the packaging of the app via aio app pack

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

aiojbot commented 11 months ago

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2556

shazron commented 10 months ago

Closed via https://github.com/adobe/aio-cli-plugin-app/pull/727