adobe / aio-cli-plugin-app

Create, Build and Deploy Cloud Native Applications
Apache License 2.0
19 stars 35 forks source link

fix: pin eslint-plugin-n to ^15.7 to support node 14 #730

Closed MichaelGoberling closed 11 months ago

MichaelGoberling commented 12 months ago

Description

Version ^16.0 of eslint-plugin-n doesn't support Node 14, but aio still does. Pin to ^15.7 for now

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

MichaelGoberling commented 12 months ago

Tests are failing here during npm install trying to resolve the dependency tree. Once we get the shared eslint config PR merged and released, this should be fixed

codecov[bot] commented 12 months ago

Codecov Report

Merging #730 (4eafa12) into master (c5b8b54) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #730   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3207      3207           
  Branches       605       605           
=========================================
  Hits          3207      3207           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more