Closed shazron closed 11 months ago
Merging #736 (1a0f0cd) into master (bc39f62) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #736 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 3223 3229 +6
Branches 607 607
=========================================
+ Hits 3223 3229 +6
Files | Coverage Δ | |
---|---|---|
src/commands/app/pack.js | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
FYI @sangeetha5491 - slight change to the artifacts folder being passed in to the hook.
Changes LGTM!
Follow up Q: Is there a known use case for being able to configure the output of the app zip? It seems useful, but I was wondering if we could maybe reduce the chance a dev accidentally packages
foo/app.zip
if the app zip always goes indist/app.zip
The use case is if an ISV wants to automate and put all packages into a known folder, and they can name it immediately to what they want, say for archiving. Say --output ~/Desktop/my-app-packages/my-project-abc-2023-10-12.zip
These files have been moved:
app-package
artifacts folder has been moved todist/app-package
app.zip
has been moved todist/app.zip
.This has been added:
dist
folders are excluded from the packdist
folder itself is excluded from the pack (just in case the .gitignore value is not there)dist/app-package
folder will be deleted after the packHow Has This Been Tested?
aio app pack
on an App Builder projectTypes of changes
Checklist: