adobe / aio-cli-plugin-app

Create, Build and Deploy Cloud Native Applications
Apache License 2.0
19 stars 35 forks source link

Enable deployment of blackboxes to local openwhisk via `docker` manifest property #739

Closed hparra closed 10 months ago

hparra commented 10 months ago

Description

[1] https://github.com/adobe/aio-lib-runtime/blob/e8815561e7d7e06e75e8f4d8cc6ef69da12fb7d2/src/utils.js#L1494

Related Issue

740

Motivation and Context

I was developing a blackbox image locally before I had access to feature. Each time the actions are redeployed on code change I also have to rerun wsk action update ... --docker ... to update the container, but this seams unnecessary as the manifest already supports this.

How Has This Been Tested?

This has been tested locally by monkeypatching these changes in local node_modules and successfully deploying a blackbox to my local openwhisk using the docker manifest property only.

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 10 months ago

Codecov Report

Merging #739 (5b7f031) into master (2d9e9f5) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #739   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3188      3188           
  Branches       599       599           
=========================================
  Hits          3188      3188           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

hparra commented 10 months ago

@shazron Agreed but now taking different approach. Change in https://github.com/adobe/aio-lib-runtime/pull/168 fixes both local and cloud. I have updated https://github.com/adobe/aio-cli-plugin-app/issues/740. I will reopen this if necessary.