fix: update openwhisk standalone config for new node-20 runtime and tags

adobe / aio-cli-plugin-app

Create, Build and Deploy Cloud Native Applications

Apache License 2.0

19 stars 35 forks source link

fix: update openwhisk standalone config for new node-20 runtime and tags #741

Closed shazron closed 10 months ago

shazron commented 10 months ago

How Has This Been Tested?

aio app run --local should download the appropriate image in Docker

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

codecov[bot] commented 10 months ago

Codecov Report

Merging #741 (86c3ac9) into master (2d9e9f5) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #741   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3188      3188           
  Branches       599       599           
=========================================
  Hits          3188      3188

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

MichaelGoberling commented 10 months ago

Looks like last time this was completed by Jesse (commit), the default kind was updated to the latest

Should we do that here too or is there a reason we're deferring?

shazron commented 10 months ago

@MichaelGoberling The default kind is determined by the default key in the output of curl https://adobeioruntime.net (which runtimes.json is).

shazron commented 10 months ago

Sorry I was confused - runtimes.json is just our own version of the curl output. There is no reason it should be tied to the actual runtime server default kind, but maybe it should?