adobe / aio-cli-plugin-app

Create, Build and Deploy Cloud Native Applications
Apache License 2.0
19 stars 35 forks source link

fix: increase jest timeout to 30s from 15s #744

Closed shazron closed 9 months ago

shazron commented 9 months ago

This is to fix timeout issues under node-14 for the Github Action daily.yml See https://github.com/adobe/aio-cli-plugin-app/actions/runs/6857278020

How Has This Been Tested?

This PR is the test.

Types of changes

Checklist:

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cba5501) 100.00% compared to head (b446782) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #744 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 56 56 Lines 3233 3233 Branches 612 612 ========================================= Hits 3233 3233 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shazron commented 9 months ago

At 30s, ubuntu node-14 builds now don't timeout, but now windows node-14 builds time out. Increasing timeout to 45s.

shazron commented 9 months ago

Now Ubuntu node-14 is failing also when its passing before. Not sure what's going on. I have a suspicion it's an infra issue.

shazron commented 9 months ago

Might not be relevant anymore once we merge #745