fix: ACNA-2399 - update app config lib major

moritzraho commented 9 months ago

Description

~depends on https://github.com/adobe/aio-cli-lib-app-config/pull/32 + major release and update major here, DO NOT MERGE/RELEASE before as otherwise every command would trigger validation.~ this plugin major update will be part of the aio-cli@v10 release, in the next commit

NOTE: by default validateAppConfig is set to false when calling load on aio-cli-lib-app-config. We set it to true for pack.

relates to ACNA-2399

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

purplecabbage commented 9 months ago

I don't think these heroics are actually required as the next release will be a major and lock a node version that supports this:

  "dependencies": {
    "@adobe/aio-cli-lib-app-config": "^1.1.0",
    "@adobe/aio-cli-lib-app-config-next": "npm:@adobe/aio-cli-lib-app-config@^3.0.0",

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (75539c9) 100.00% compared to head (2a39ae3) 100.00%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #751 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 56 56 Lines 3232 3236 +4 Branches 612 612 ========================================= + Hits 3232 3236 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adobe / aio-cli-plugin-app