adobe / aio-cli-plugin-app

Create, Build and Deploy Cloud Native Applications
Apache License 2.0
19 stars 35 forks source link

confirm-new-workspace weirdness #753

Closed purplecabbage closed 7 months ago

purplecabbage commented 9 months ago

Describe the bug There is some confusion around this feature, the flag is defined as

  'confirm-new-workspace': Flags.boolean({
    description: 'Skip and confirm prompt for creating a new workspace',
    default: false
  }),

What the flag does is skip over blocking to wait for confirmation before creating a new workspace. This flag should be more like

  'confirm-new-workspace': Flags.boolean({
    description: 'Confirm before creating a new workspace',
    default: true,
    allowNo: true,
  }),

It should also depend on the -w flag, we don't create a new workspace unless they specify one ...

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

aiojbot commented 9 months ago

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2676