adobe / aio-cli-plugin-app

Create, Build and Deploy Cloud Native Applications
Apache License 2.0
19 stars 35 forks source link

Misleading Errors in Updating Published Actions #761

Closed kumargg14 closed 5 months ago

kumargg14 commented 5 months ago

Describe the bug The app is published in production workspace, On modifying any assets or actions and re-executing command "aio app deploy --force-deploy" will result in error though the changes are updated.

To Reproduce Steps to reproduce the behavior:

  1. Create and publish the app.
  2. Update the actions or any web assets
  3. Deploy the app using "aio app deploy" or aio app deploy --force-deploy

Expected behavior The deployment shouldn't throw an error as we are not updating the app endpoints in app registry

Screenshots If applicable, add screenshots to help explain your problem.

Screenshot 2024-02-02 at 1 22 57 PM

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

MichaelGoberling commented 5 months ago

Yeah this error is coming from the Developer Console. To avoid these errors, I'm thinking we skip publishing if --force-deploy is specified and the user is working in a published prod app. Also make --force-deploy mutually exclusive with --publish and --force-publish

cc: @moritzraho @purplecabbage

aiojbot commented 5 months ago

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2818

moritzraho commented 5 months ago

sounds good to me 👍