using verbose flag sometimes results in TypeError

MichaelGoberling commented 2 months ago

Describe the bug running aio app <command> --verbose sometimes results in the following error:

TypeError: first argument must be a string or instance of Error

this is because errors caught by the BaseCommand dont always have stack traces (error.stack) https://github.com/adobe/aio-cli-plugin-app/blob/master/src/BaseCommand.js#L38

To Reproduce Steps to reproduce the behavior:

Create an app with frontend
Try to import from a file that doesnt exist (i.e. import { NonexistentFile } from './NonexistentFile')
run aio app build --verbose
see TypeError: first argument must be a string or instance of Error

Expected behavior

Create an app with frontend
Try to import from a file that doesnt exist
aio app build --verbose
see Error: Failed to resolve './NonexistentFile' from './web-src/src/components/NonexistentFile.js'

(funny enough the expected behavior is what you see when you dont use the --verbose flag)

Potential solution

just check for the stack trace (flags.verbose && error.stack)

MichaelGoberling commented 2 months ago

fwiw, stack is an optional field of Error https://stackoverflow.com/a/75109213/22265578

aiojbot commented 2 months ago

adobe / aio-cli-plugin-app