adobe / aio-cli-plugin-app

Create, Build and Deploy Cloud Native Applications
Apache License 2.0
19 stars 35 forks source link

upcase all keys before storing in .env #797

Open purplecabbage opened 2 months ago

purplecabbage commented 2 months ago

Description

Related Issue

Confusing lowercase .env keys adobe/aio-cli

I have not updated the tests as this really just means upcasing all the fixtures and I want to be sure there are no unexpected side-effects before heavy handedly making the tests pass.

Motivation and Context

I was confused ... I still am about this key: AIO_ims_contexts_Credential__in__Jesse__Is__Back__-__Stage_client__id

- is not valid in an identifier/property name, so this becomes: ( note the ticks )

  AIO_RUNTIME_APIHOST: 'https://adobeioruntime.net',
  'AIO_IMS_CONTEXTS_CREDENTIAL__IN__JESSE__IS__BACK__-__STAGE_CLIENT__ID': ...

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

shazron commented 2 months ago

tests are now failing