fix: ACNA-2509 - zipfile does not exist due to hard-coded path

shazron commented 10 months ago

Description

daily asset compute integration smoke tests were failing: https://github.com/adobe/aio-e2e-tests/actions/runs/6031496162

the test that failed: https://github.com/adobe/asset-compute-integration-tests/blob/995c349be023326248cdfb2f7f8c182cb8a392e3/test/index.test.js#L64

The failure is due to the hard-coded location of the action zip -- this relied on legacy behaviour where we symlinked the old location of the zips to their new locations which in sub-folders named after the action's package name.

The symlinks were removed because they caused issues in Windows for devs:

This patch is better since it relies on the the zip locations returned by the runtime lib itself, and the locations are virtually guaranteed to exist.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

adobe-bot commented 10 months ago

🎉 Sizewatcher congratulates on the size improvement 📉:

🎉 git -79.2% (2.86 MB => 595 kB)

✅ node_modules +2.8% (270 MB => 278 MB)

Largest production node modules:

┌───────────────────────────────┬────────────┬────────┐
│ name                          │ children   │ size   │
├───────────────────────────────┼────────────┼────────┤
│ @adobe/asset-compute-devtool  │ 0          │ 18.35M │
├───────────────────────────────┼────────────┼────────┤
│ @adobe/aio-lib-runtime        │ 0          │ 0.65M  │
├───────────────────────────────┼────────────┼────────┤
│ request                       │ 0          │ 0.55M  │
├───────────────────────────────┼────────────┼────────┤
│ @oclif/core                   │ 0          │ 0.28M  │
├───────────────────────────────┼────────────┼────────┤
│ js-yaml                       │ 0          │ 0.28M  │
├───────────────────────────────┼────────────┼────────┤
│ requestretry                  │ 0          │ 0.05M  │
├───────────────────────────────┼────────────┼────────┤
│ glob                          │ 0          │ 0.05M  │
├───────────────────────────────┼────────────┼────────┤
│ @adobe/aio-cli-lib-app-config │ 0          │ 0.04M  │
├───────────────────────────────┼────────────┼────────┤
│ minimatch                     │ 0          │ 0.03M  │
├───────────────────────────────┼────────────┼────────┤
│ http-terminator               │ 0          │ 0.03M  │
├───────────────────────────────┼────────────┼────────┤
│ + 5 modules                   │            │        │
├───────────────────────────────┼────────────┼────────┤
│ 15 modules                    │ 0 children │ 20.37M │
└───────────────────────────────┴────────────┴────────┘

✅ npm_package +0.4% (28.3 kB => 28.4 kB)

Package contents:

📦  @adobe/aio-cli-plugin-asset-compute@4.0.3
=== Tarball Contents === 
3.2kB  CODE_OF_CONDUCT.md                                  
171B   COPYRIGHT                                           
11.3kB LICENSE                                             
5.9kB  README.md                                           
897B   bin/run                                             
3.6kB  oclif.manifest.json                                 
2.5kB  package.json                                        
6.0kB  src/base-command.js                                 
1.8kB  src/commands/asset-compute/devtool.js               
1.0kB  src/commands/asset-compute/index.js                 
7.7kB  src/commands/asset-compute/run-worker.js            
5.4kB  src/commands/asset-compute/test-worker.js           
3.1kB  src/hooks/init.js                                   
13.4kB src/lib/actionrunner.js                             
3.0kB  src/lib/cloudfiles.js                               
1.3kB  src/lib/mock-crt/CertificateAuthorityCertificate.pem
5.5kB  src/lib/mockserver.js                               
4.7kB  src/lib/testresults.js                              
21.2kB src/lib/testrunner.js                               
5.5kB  src/lib/util.js                                     
1.4kB  src/lib/workerrunner.js                             
=== Tarball Details === 
name:          @adobe/aio-cli-plugin-asset-compute         
version:       4.0.3                                       
filename:      adobe-aio-cli-plugin-asset-compute-4.0.3.tgz
package size:  28.4 kB                                     
unpacked size: 108.7 kB                                    
shasum:        1f8f2147c21bc160479890aac22217981bd2a8f3    
integrity:     sha512-miPUVEgSEGPIr[...]CdWjjVXksbClg==    
total files:   21                                          

npm WARN This command requires you to be logged in to https://registry.npmjs.org/ (dry-run)
Publishing to https://registry.npmjs.org/ with tag latest and default access (dry-run)

Notes

- PR branch: `remove-legacy-behavior` @ e741e72e262a8a5ade89577324d5b9c382d41db1 - Base branch: `master` - Sizewatcher v1.3.0 - Effective Configuration: ```yaml limits: fail: 100% warn: 30% ok: '-10%' report: githubComment: true githubStatus: false comparators: {} ```

codecov[bot] commented 10 months ago

Codecov Report

Merging #108 (e741e72) into master (7304cbc) will increase coverage by 0.13%. Report is 1 commits behind head on master. The diff coverage is 100.00%.

:exclamation: Current head e741e72 differs from pull request most recent head 2d47e93. Consider uploading reports for the commit 2d47e93 to get more accurate results

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   90.95%   91.09%   +0.13%     
==========================================
  Files          13       13              
  Lines         851      853       +2     
==========================================
+ Hits          774      777       +3     
+ Misses         77       76       -1

Files Changed	Coverage Δ
src/base-command.js	`95.89% <100.00%> (+1.52%)`	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

adobe-bot commented 10 months ago

:tada: This PR is included in version 4.0.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

adobe / aio-cli-plugin-asset-compute