adobe / aio-cli-plugin-asset-compute

Asset Compute Plugin for Adobe I/O Command Line Interface
Apache License 2.0
1 stars 7 forks source link

fix: add kinds nodejs:18 and nodejs:20, update all image versions to 3.0.41 #109

Open shazron opened 8 months ago

shazron commented 8 months ago

Description

Required by https://github.com/adobe/asset-compute-integration-tests/pull/43 Needs a new plugin release as well, after.

nodejs:18 is the default kind, and nodejs:20 is also supported: run curl https://adobeioruntime.net to see all images supported and tags.

Types of changes

Checklist:

shazron commented 7 months ago

@tmathern How can I get the tests to pass? I think the tests don't run because its on a fork.

tmathern commented 6 months ago

@tmathern How can I get the tests to pass? I think the tests don't run because its on a fork.

Try to run them locally, post the test report and we'd be good! (Do you see the logs/failures? You should be able to...).

shazron commented 6 months ago

@tmathern I can't make the tests pass - they don't even pass on the master branch (which of course doesn't have my code). So it seems that it is something that needs to be fixed in master first? I tried to dig into it but I couldn't find where that failing code is exactly.

I tested on macOS, Linux, and even Windows (but the tests don't even run on Windows - the call to docker has "too many colons")

The common error is (34 failures):

Actions:
- worker

Running tests in test/asset-compute/worker

Error: Could not init action on container (POST http://0.0.0.0:32792/init: responded with error: Initialization has failed due to: /nodejsAction/aKxyo343/index.js:116417
                size.type = size.type ?? type;
                                       ^

SyntaxError: Unexpected token ?
    at Module._compile (internal/modules/cjs/loader.js:723:23)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at eval (eval at <anonymous> (/nodejsAction/runner.js:65:49), <anonymous>:1:1)
    at /nodejsAction/runner.js:65:49
    at process._tickCallback (internal/process/next_tick.js:68:7)