alexkli commented 4 years ago

Note: This PR builds on top of #12. To review, please go to #14 which shows just the changes for the test folder move.

For NUI-560.

Better, standard test folder location under test/ in root of aio project instead of being inside the action source folders (actions/myaction/tests).

move test folder tests to test/asset-compute/<action>
when running tests, go by test folders to lookup actions to catch any action rename issues with test failures
add test for test folder vs. action name mismatch
add test for missing tests case
improve output if no tests found

codecov[bot] commented 4 years ago

Codecov Report

Merging #13 into master will increase coverage by 0.60%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   86.20%   86.80%   +0.60%     
==========================================
  Files          10       10              
  Lines         761      758       -3     
==========================================
+ Hits          656      658       +2     
+ Misses        105      100       -5

Impacted Files	Coverage Δ
src/base-command.js	`77.19% <ø> (+1.78%)`	:arrow_up:
src/commands/asset-compute/test-worker.js	`95.55% <100.00%> (+8.71%)`	:arrow_up:
src/lib/testrunner.js	`81.22% <100.00%> (-0.43%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 855123b...fdfa29e. Read the comment docs.

adobe-bot commented 4 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

adobe / aio-cli-plugin-asset-compute

NUI-560 - move test folder #13

Codecov Report