alexkli commented 4 years ago

Instead of at container start and then be the same for all activations, set all per activation values such as deadline & activation id in the /run request as done in wskdebug.

The test case uses a worker (deadlines) that writes the deadline & activation id into the rendition as json, and has 2 test cases, so that the unit test here can read those later and check that they are not the same.

Another test fix: assertMissingOrEmptyDirectory() was not correctly asserting.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

codecov[bot] commented 4 years ago

Codecov Report

Merging #40 into master will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   90.63%   90.62%   -0.02%     
==========================================
  Files          13       13              
  Lines         822      821       -1     
==========================================
- Hits          745      744       -1     
  Misses         77       77

Impacted Files	Coverage Δ
src/lib/actionrunner.js	`89.65% <ø> (-0.09%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 325c740...5a179d4. Read the comment docs.

adobe-bot commented 4 years ago

:tada: This PR is included in version 1.4.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

adobe / aio-cli-plugin-asset-compute

NUI-877 test-worker incorrectly sets deadline on container start instead of /run #40

Types of changes

Codecov Report