adobe / aio-cli-plugin-asset-compute

Asset Compute Plugin for Adobe I/O Command Line Interface

Apache License 2.0

1 stars 7 forks source link

add debug mode to docker container in verbose mode #61

Closed jdelbick closed 3 years ago

jdelbick commented 3 years ago

Description

add DEBUG=* as an environment variable on the container in verbose mode.

Fixes # (issue)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

codecov[bot] commented 3 years ago

Codecov Report

Merging #61 (bc3f90c) into master (68bf545) will decrease coverage by 0.08%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   90.59%   90.50%   -0.09%     
==========================================
  Files          13       13              
  Lines         829      832       +3     
==========================================
+ Hits          751      753       +2     
- Misses         78       79       +1

Impacted Files	Coverage Δ
src/lib/testrunner.js	`87.78% <ø> (ø)`
src/commands/asset-compute/test-worker.js	`94.23% <75.00%> (-1.69%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd0043f...bc3f90c. Read the comment docs.

alexkli commented 3 years ago

I did this before in wskdebug: https://github.com/apache/openwhisk-wskdebug#enable-debug-logging

But simply passing the env var through - this allows better control.

code: https://github.com/apache/openwhisk-wskdebug/blob/1ec715d98136811bea30eb6a82b378d78e356252/src/kinds/nodejs/nodejs.js (Slightly different since it uses dockerode)

(I guess DEBUG might be enough, but NODE_DEBUG could be useful to)

alexkli commented 3 years ago

Replaced by #62 .