adobe / aio-cli-plugin-asset-compute

Asset Compute Plugin for Adobe I/O Command Line Interface
Apache License 2.0
1 stars 7 forks source link

NUI-1639 use aio app get-url to get the correct action urls for projects made with aio v8 #69

Closed jdelbick closed 2 years ago

jdelbick commented 2 years ago

jira: https://jira.corp.adobe.com/browse/NUI-1639 Cascading release of PR: https://github.com/adobe/asset-compute-devtool/pull/73

Types of changes

Checklist:

adobe-bot commented 2 years ago
Sizewatcher found no problematic size increases.

git has no changes (2.36 MB)
Largest files in new changes:
ee28b82af2d3  1.6MiB package-lock.json
02d3367dbb63 739KiB package-lock.json
af69ab279cf1 11KiB test/commands/init.test.js
df21d3ac070e 11KiB test/commands/init.test.js
e8847cb3295a 10KiB test/commands/init.test.js
ca7c1bf5d407 6.5KiB test/commands/testutil.js
f7b700a55ec5 6.4KiB test/commands/testutil.js
7a8cf5c71aed 2.5KiB package.json
a55d4ae1f13e 1.6KiB .github/workflows/node.js.yml
node_modules +1.6% (451 MB => 458 MB)
Largest production node modules:
┌───────────────────────────────┬────────────┬────────┐
│ name │ children │ size │
├───────────────────────────────┼────────────┼────────┤
│ @adobe/asset-compute-devtool │ 0 │ 18.32M │
├───────────────────────────────┼────────────┼────────┤
│ request │ 0 │ 0.54M │
├───────────────────────────────┼────────────┼────────┤
│ @adobe/aio-lib-runtime │ 0 │ 0.48M │
├───────────────────────────────┼────────────┼────────┤
│ js-yaml │ 0 │ 0.28M │
├───────────────────────────────┼────────────┼────────┤
│ @oclif/config │ 0 │ 0.15M │
├───────────────────────────────┼────────────┼────────┤
│ @oclif/plugin-help │ 0 │ 0.10M │
├───────────────────────────────┼────────────┼────────┤
│ @oclif/command │ 0 │ 0.06M │
├───────────────────────────────┼────────────┼────────┤
│ glob │ 0 │ 0.05M │
├───────────────────────────────┼────────────┼────────┤
│ requestretry │ 0 │ 0.05M │
├───────────────────────────────┼────────────┼────────┤
│ @adobe/aio-cli-lib-app-config │ 0 │ 0.04M │
├───────────────────────────────┼────────────┼────────┤
│ + 7 modules │ │ │
├───────────────────────────────┼────────────┼────────┤
│ 17 modules │ 0 children │ 20.19M │
└───────────────────────────────┴────────────┴────────┘
npm_package has no changes (28.4 kB)
Package contents:
📦  @adobe/aio-cli-plugin-asset-compute@2.0.0
=== Tarball Contents ===
171B COPYRIGHT
11.3kB LICENSE
846B bin/run
12.9kB src/lib/actionrunner.js
6.8kB src/base-command.js
3.0kB src/lib/cloudfiles.js
1.8kB src/commands/asset-compute/devtool.js
1.0kB src/commands/asset-compute/index.js
3.1kB src/hooks/init.js
5.5kB src/lib/mockserver.js
7.7kB src/commands/asset-compute/run-worker.js
5.4kB src/commands/asset-compute/test-worker.js
4.7kB src/lib/testresults.js
21.2kB src/lib/testrunner.js
5.1kB src/lib/util.js
1.4kB src/lib/workerrunner.js
3.2kB oclif.manifest.json
2.5kB package.json
3.2kB CODE_OF_CONDUCT.md
5.8kB README.md
1.3kB src/lib/mock-crt/CertificateAuthorityCertificate.pem
=== Tarball Details ===
name: @adobe/aio-cli-plugin-asset-compute
version: 2.0.0
package size: 28.4 kB
unpacked size: 108.0 kB
shasum: e8d3de6e355a3d0e47bba793d38a4d6624a1bde5
integrity: sha512-VpMgXiliOdhQO[...]t1dhNfkueNjgw==
total files: 21
Notes
- PR branch: `NUI-1639` @ 47b0766453915d2f9d29d0221ae7022ed018bb33 - Base branch: `master` - Sizewatcher v1.2.0 - Effective Configuration: ```yaml limits: fail: 100% warn: 30% ok: '-10%' report: githubComment: true githubStatus: false comparators: {} ```

codecov[bot] commented 2 years ago

Codecov Report

Merging #69 (47b0766) into master (37769ec) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files          13       13           
  Lines         850      850           
=======================================
  Hits          772      772           
  Misses         78       78           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37769ec...47b0766. Read the comment docs.

jdelbick commented 2 years ago

nodejs 10 tests are flakey due to timeouts: https://github.com/adobe/aio-cli-plugin-asset-compute/runs/4183164328?check_suite_focus=true

  1) test-worker command
       success
         runs successful tests with cloud files:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/aio-cli-plugin-asset-compute/aio-cli-plugin-asset-compute/test/commands/run-worker.test.js)

we should probably remove nodejs10 from the tests since aio doesn't support it anyways. however for now, I just increased the timeouts

adobe-bot commented 2 years ago

:tada: This PR is included in version 2.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: