adobe / aio-cli-plugin-asset-compute

Asset Compute Plugin for Adobe I/O Command Line Interface

Apache License 2.0

1 stars 7 forks source link

Migrate code to Oclif-2 #83

Closed purplecabbage closed 2 years ago

purplecabbage commented 2 years ago

Description

Oclif-1 will not be supported soon. This migrates all code to use Oclif-2 The aio-cli and all core plugins will soon be using Oclif-2 ( next major )

Fixes # (issue)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.

codecov[bot] commented 2 years ago

Codecov Report

Merging #83 (717ca21) into master (edf1cd3) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   90.89%   90.89%           
=======================================
  Files          13       13           
  Lines         857      857           
=======================================
  Hits          779      779           
  Misses         78       78

Impacted Files	Coverage Δ
src/base-command.js	`93.50% <100.00%> (ø)`
src/commands/asset-compute/devtool.js	`81.25% <100.00%> (ø)`
src/commands/asset-compute/index.js	`100.00% <100.00%> (ø)`
src/commands/asset-compute/run-worker.js	`89.28% <100.00%> (ø)`
src/commands/asset-compute/test-worker.js	`96.29% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

tmathern commented 2 years ago

@purplecabbage Do you need us to review the PR? Reviewers would be @jdelbick @pheenomenon @tmathern .

purplecabbage commented 2 years ago

This is ready for review. Attn: @jdelbick @pheenomenon @tmathern

tmathern commented 2 years ago

(I added @badvision and @pheenomenon as reviewers too)

adobe-bot commented 2 years ago

:tada: This PR is included in version 4.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: