adobe / aio-cli-plugin-asset-compute

Asset Compute Plugin for Adobe I/O Command Line Interface

Apache License 2.0

1 stars 7 forks source link

Update aio-lib-runtime major #91

Closed purplecabbage closed 1 year ago

purplecabbage commented 2 years ago

Description

This uses the new bin script method of running your command. Updated aio-lib-runtime version to support worker:runtime:nodejs:16 @oclif/config => (@oclif/core).Config Fixes # (issue)

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 2 years ago

Codecov Report

Merging #91 (56a04e2) into master (f315b1e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   90.89%   90.89%           
=======================================
  Files          13       13           
  Lines         857      857           
=======================================
  Hits          779      779           
  Misses         78       78

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jdelbick commented 2 years ago

I will merge this on Friday or next week. I have a presentation for consultants for field enablement on Thursday and I want to wait to merge this until after since I won't have time to validate aio v9 works for Asset Compute Custom Workers.

jdelbick commented 1 year ago

i will merge as a bugfix release: https://cq-dev.slack.com/archives/C013UDBFBGB/p1665161697013669?thread_ts=1664386796.277959&cid=C013UDBFBGB

Older versions should still target the previous version of the plugin. With semver we should be okay.

adobe-bot commented 1 year ago

:tada: This PR is included in version 4.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: