adobe / aio-cli-plugin-console

Adobe's Developer Console plugin for the Adobe I/O CLI
https://www.adobe.io
Apache License 2.0
6 stars 11 forks source link

Workspace Enhancements #133

Closed sandeep-paliwal closed 4 years ago

sandeep-paliwal commented 4 years ago

Fixes #117

Added support to show cumulative errors for workspace commands Added optional arg to specify destination for workspace download command Moved config key to common file

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #133 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #133   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          295       315   +20     
  Branches        31        35    +4     
=========================================
+ Hits           295       315   +20     
Impacted Files Coverage Δ
src/commands/console/workspace/download.js 100.00% <100.00%> (ø)
src/commands/console/workspace/list.js 100.00% <100.00%> (ø)
src/commands/console/workspace/select.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 605301d...2f3a810. Read the comment docs.

purplecabbage commented 4 years ago

I think you're going to need to revert 'Use common constants file for workspace commands' as it is covered by #132