adobe / aio-cli-plugin-console

Adobe's Developer Console plugin for the Adobe I/O CLI
https://www.adobe.io
Apache License 2.0
6 stars 11 forks source link

feat: config upgrade via hook #147

Closed shazron closed 4 years ago

shazron commented 4 years ago

Description

The config keys for console config for the org, project and workspace settings is changing. Currently it is under the key $console. This has been changed to console (no $ prefix).

An init hook is added that will check the user's config, and will migrate an older key to the new key, if the older key exists.

However, If the new key already exists, there will be no migration, nor will the older key be deleted.

How Has This Been Tested?

npm test

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #147 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #147   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        14    +2     
  Lines          350       372   +22     
  Branches        35        36    +1     
=========================================
+ Hits           350       372   +22     
Impacted Files Coverage Δ
src/commands/console/index.js 100.00% <100.00%> (ø)
src/commands/console/org/select.js 100.00% <100.00%> (ø)
src/commands/console/project/select.js 100.00% <100.00%> (ø)
src/commands/console/workspace/download.js 100.00% <100.00%> (ø)
src/commands/console/workspace/list.js 100.00% <100.00%> (ø)
src/commands/console/workspace/select.js 100.00% <100.00%> (ø)
src/config.js 100.00% <100.00%> (ø)
src/hooks/upgrade-config-hook.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 887a6b7...cf3d2eb. Read the comment docs.

purplecabbage commented 4 years ago

This is looking good. I was expecting the hook to live in the config lib directly, since it already has a hook. We can remove the previous code from the hook too.