adobe / aio-cli-plugin-console

Adobe's Developer Console plugin for the Adobe I/O CLI
https://www.adobe.io
Apache License 2.0
6 stars 11 forks source link

ACNA-1833 | Externalising github workflows #211

Closed amulyakashyap09 closed 9 months ago

amulyakashyap09 commented 10 months ago

Description

Implement reusable github workflows

Related Issue

ACNA-1833

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3ba4dc5) 100.00% compared to head (5bb32aa) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #211 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 19 19 Lines 546 546 Branches 82 82 ========================================= Hits 546 546 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shazron commented 9 months ago

lgtm, but some test results are pending

actually, no. It's the branch settings for required checks, which reference the old workflows. The new tests (build/build/...) pass fine. @amulyakashyap09 needs to update those, but it's a chicken and egg thing...

shazron commented 9 months ago

@amulyakashyap09 Needs required checks change in Branch protection settings.