search

adobe / aio-cli-plugin-runtime

Adobe I/O Runtime plugin for the Adobe I/O CLI
https://www.adobe.io
Apache License 2.0
15 stars 31 forks source link

Add typescript file recognition #211

Closed rabbah closed 3 years ago

rabbah commented 3 years ago

Is your feature request related to a problem? Please describe. The list of recognized runtimes does not include typescript (.ts extensions). This would be useful to allow other aio to work with other openwhisk compatible deployments.

Describe the solution you'd like I've created a patch https://github.com/adobe/aio-cli-plugin-runtime/compare/master...rabbah:ts?expand=1 and will open a PR if desirable.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

meryllblanchet commented 3 years ago

Hi @rabbah and thank you for another great suggestion!

Looping in @sarahxxu and @mcorlan again for a feature review.

sarahxxu commented 3 years ago

LGTM on this PR. Although Runtime doesn't currently support Typescript, I can see this helpful for Openwhisk users who want to share the tooling! cc @rabbah @mcorlan

meryllblanchet commented 3 years ago

@Himavanth or @purplecabbage could you review @rabbah 's PR?

aiojbot commented 3 years ago

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-1008