search

adobe / aio-cli-plugin-runtime

Adobe I/O Runtime plugin for the Adobe I/O CLI
https://www.adobe.io
Apache License 2.0
15 stars 31 forks source link

add flag to show action code #212

Closed rabbah closed 3 years ago

rabbah commented 3 years ago

Is your feature request related to a problem? Please describe. When using action get, add a flag to show the action's code, when the code is in text form. Additionally, add a global flag that allows action get to show the full action document as JSON when desirable.

Describe the solution you'd like I've implemented a patch available here https://github.com/adobe/aio-cli-plugin-runtime/compare/master...rabbah:code?expand=1 and will open a PR if desirable.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

meryllblanchet commented 3 years ago

Hi @rabbah and thank you for the great suggestion!

Let me loop in @sarahxxu and @mcorlan for a feature review.

sarahxxu commented 3 years ago

@rabbah I can see use cases where this could be very helpful! Let's coordinate on the language of the flag to make sure we are consistent. Is the proposed flag --code (-c for short?)

cc @meryllblanchet @mcorlan

rabbah commented 3 years ago

Yep --code and -c are what I proposed in https://github.com/adobe/aio-cli-plugin-runtime/compare/master...rabbah:code?expand=1#diff-4a40868c6c94c0bcf8936e9402bf9274a339027961f7234418e806cd51a62506R104-R107.

sarahxxu commented 3 years ago

👍 lgtm!

meryllblanchet commented 3 years ago

@Himavanth or @purplecabbage could you review @rabbah 's PR?

aiojbot commented 3 years ago

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-1009