adobe / aio-cli-plugin-runtime

Adobe I/O Runtime plugin for the Adobe I/O CLI

https://www.adobe.io

Apache License 2.0

15 stars 31 forks source link

Add typescript kind. #214

Closed rabbah closed 3 years ago

rabbah commented 3 years ago

Description

This add file/runtime kind recognition for Typescript. While AIO may not support it, it permits the CLI to be used with other deployments. The API server should reject any runtime that is not supported by the deployment.

Related Issue

Closes #211.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 3 years ago

Codecov Report

Merging #214 (b0799de) into master (17c3299) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #214   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         1441      1443    +2     
  Branches       258       260    +2     
=========================================
+ Hits          1441      1443    +2

Impacted Files	Coverage Δ
src/kinds.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17c3299...b0799de. Read the comment docs.

rabbah commented 3 years ago

There is a ts runtime https://github.com/apache/openwhisk-runtime-nodejs/tree/master/core/typescript37Action.

There’s some doc work needed before adding to the runtime manifest in the core repo https://github.com/apache/openwhisk/issues/4872.

Himavanth commented 3 years ago

Understood. Thx for the info @rabbah . Merging.