adobe / aio-cli-plugin-runtime

Adobe I/O Runtime plugin for the Adobe I/O CLI
https://www.adobe.io
Apache License 2.0
15 stars 31 forks source link

Fix likely error in activation logs logic (#20) #216

Closed rabbah closed 3 years ago

rabbah commented 3 years ago

printActionLogs is async (returns a promise) so should be awaited. This won't matter much in a CLI but when the command is embedded in another context it can cause the logic of the caller to race ahead of printing the output.

Description

Closes #209.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 3 years ago

Codecov Report

Merging #216 (e1d353f) into master (e0c8b31) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #216   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         1441      1441           
  Branches       258       258           
=========================================
  Hits          1441      1441           
Impacted Files Coverage Δ
src/commands/runtime/activation/logs.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0c8b31...e1d353f. Read the comment docs.