florind-ens commented 3 years ago

Description

Motivation and Context

startTime is being used to filter out the logs to be printed. While --tail or any other continuously fetching param, it should only fetch logs since Date.now().

How Has This Been Tested?

Steps:

cd into the generated firefly project.
run aio runtime activation logs --tail.
While aio runtime activation logs --tail is running, generate some logs via the firefly app. Expected: Only logs following the aio runtime activation logs --tail should be printed.

Steps:

cd firefly project.
run aio runtime activation logs Expected: Logs prior to aio runtime activation logs should be printed.

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 3 years ago

Codecov Report

Merging #245 (a7aeff0) into master (50d92b4) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #245   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           58        58           
  Lines         1568      1570    +2     
  Branches       311       312    +1     
=========================================
+ Hits          1568      1570    +2

Impacted Files	Coverage Δ
src/commands/runtime/activation/logs.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50d92b4...a7aeff0. Read the comment docs.

shazron commented 3 years ago

@florind12 please fill in the section How Has This Been Tested?

Himavanth commented 3 years ago

Closing this as this has been dealt with in https://github.com/adobe/aio-lib-runtime/pull/67#issuecomment-902739633

adobe / aio-cli-plugin-runtime

[ACNA-1106] Omit old logs while continuous logs fetching #245